On Wed, Jan 4, 2017 at 11:00 AM, Appana Durga Kedareswara Rao <appana.durga.rao@xxxxxxxxxx> wrote: > Hi Rob, > > Thanks for the review.... > >> On Wed, Jan 04, 2017 at 07:05:53PM +0530, Kedareswara rao Appana wrote: >> > When VDMA is configured for more than one frame in the h/w for example >> > h/w is configured for n number of frames and user Submits n number of >> > frames and triggered the DMA using issue_pending API. >> > In the current driver flow we are submitting one frame at a time but >> > we should submit all the n number of frames at one time as the h/w Is >> > configured for n number of frames. >> >> Please fix run-on sentences, capitalization, and word wrapping. > > Sure will fix in the next version.... > > [Snip] > -- a/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt >> > +++ b/Documentation/devicetree/bindings/dma/xilinx/xilinx_dma.txt >> > @@ -66,6 +66,8 @@ Optional child node properties: >> > Optional child node properties for VDMA: >> > - xlnx,genlock-mode: Tells Genlock synchronization is >> > enabled/disabled in hardware. >> > +- xlnx,fstore-config: Tells Whether Frame Store Configuration is >> > + enabled/disabled in hardware. >> >> What's the default (when not present)? That should be the most common case. >> Looks like the code treats this as bool, but that's not clear here. The name is not >> clear what it is doing. Enabling or disabling the feature? > > Default value is zero... > When this property is present it tells hardware is configured for frame store configuration. So most people will not want "frame store configuration"? > Will fix the explanation part in the next version like below. > xlnx,fstore-config: Tells hardware is configured for frame store configuration. > Is the above explanation clear??? No, I mean make it obvious from the name of the property: xlnx,fstore-config-enable or xlnx,fstore-enable And the description needs to say it is boolean. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
