On 16/12/2016 11:56, Marc Gonzalez wrote: > On 07/11/2016 10:18, Arnd Bergmann wrote: >> On Tuesday, October 25, 2016 3:15:50 PM CET Marc Gonzalez wrote: >>> Add the tango NAND Flash Controller dt bindings documentation. >>> >>> Signed-off-by: Marc Gonzalez <marc_gonzalez@xxxxxxxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/mtd/tango-nand.txt | 38 ++++++++++++++++++++++++++++++ >>> 1 file changed, 38 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mtd/tango-nand.txt b/Documentation/devicetree/bindings/mtd/tango-nand.txt >>> new file mode 100644 >>> index 000000000000..3cbf95d6595a >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/mtd/tango-nand.txt >>> @@ -0,0 +1,38 @@ >>> +Sigma Designs Tango4 NAND Flash Controller (NFC) >>> + >>> +Required properties: >>> + >>> +- compatible: "sigma,smp8758-nand" >>> +- reg: address/size of nfc_reg, nfc_mem, and pbus_reg >>> +- dmas: reference to the DMA channel used by the controller >>> +- dma-names: "nfc_sbox" >> >> Drop the "nfc_" prefix here, it seems redundant. > > I took a closer look at Documentation/devicetree/bindings and > arch/arm/boot/dts and it seems the overwhelming nomenclature > is "rx", "tx" (with variants around these two). > > Should I just use "rxtx" for my driver? On IRC, Arnd wrote: "The string for dma-names is not important, it just needs to be documented in the binding. If you have hardware specifications, use the name that is next to the wire for the dma-request line. "dma-names" is only required so you can connect a single dmarq to multiple dma engines (most chips only connect each rq to one dmaengine though)." In my system, peripheral devices are connected to DMA channels via a multiplexer called the "host switch box". The documentation calls the ports FOO_SBOX and SBOX_FOO. For MLC NAND Flash controller 0, the ports are mlc_flash0_sbox and sbox_mlc_flash0. Additionally, the DMA driver handles both directions, so the DT only defines a single duplex channel. I originally used "nfc_sbox" (nfc = NAND Flash controller) to stick to the HW naming, but I am willing to change it to "rxtx" if that's what Boris prefers, (or just "sbox", but Mans pointed out that this was too specific, and future HW might do away with the switch box). I'm open to comments. Regards. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
