On Fri, Dec 16, 2016 at 02:26:33PM +0100, Marc Gonzalez wrote: > On 16/12/2016 11:56, Marc Gonzalez wrote: > > Should I just use "rxtx" for my driver? > > On IRC, Arnd wrote: > > "The string for dma-names is not important, it just needs to be documented > in the binding. If you have hardware specifications, use the name that is > next to the wire for the dma-request line. "dma-names" is only required so > you can connect a single dmarq to multiple dma engines (most chips only > connect each rq to one dmaengine though)." > > In my system, peripheral devices are connected to DMA channels via > a multiplexer called the "host switch box". The documentation calls > the ports FOO_SBOX and SBOX_FOO. > > For MLC NAND Flash controller 0, the ports are mlc_flash0_sbox > and sbox_mlc_flash0. > > Additionally, the DMA driver handles both directions, so the DT only > defines a single duplex channel. > > I originally used "nfc_sbox" (nfc = NAND Flash controller) to stick to > the HW naming, but I am willing to change it to "rxtx" if that's what > Boris prefers, (or just "sbox", but Mans pointed out that this was too > specific, and future HW might do away with the switch box). "rxtx" is the best option, if you need a name at all. The name is relative to the device instance, so "nfc_" is unnecessary; we know the node is an NFC controller. The sbox is part of the SoC wiring rather than being part of the NFC controller, so the "sbox" part also shouldn't be part of the name. Likewise for the NAND flash controller. There, the "0" instance number also shouldn't have been there -- the name is relative to the instance, and two instances should use the same names. Too late now, I guess. :( Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
