On Thu, Dec 14, 2016 at 05:23:02PM +0800, Rob Herring wrote: > On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@xxxxxxx> wrote: > > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: > >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: > >> > From: Yuan Yao <yao.yuan@xxxxxxx> > >> > >> Same problem in this subject too. > >> > >> > > >> > new compatible string: "fsl,ls1012a-qspi". > >> > > >> > Signed-off-by: Yuan Yao <yao.yuan@xxxxxxx> > >> > --- > >> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + > >> > 1 file changed, 1 insertion(+) > >> > >> Acked-by: Rob Herring <robh@xxxxxxxxxx> > > > > Thanks for your review. > > And do you have any suggestion for this subject? > > The problem is you have a space in the compatible string: "fsl, ls1012a-qspi" > rather than "fsl,ls1012a-qspi" > > Also, I prefer "dt/bindings: " as the beginning of binding patch subjects. > Ok, Get it. Thanks for your comments. I will send v2 soon. ��.n��������+%������w��{.n����z�{��ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f