On Mon, Dec 12, 2016 at 8:47 PM, Yao Yuan <yao.yuan@xxxxxxx> wrote: > On Thu, Dec 13, 2016 at 05:23:02PM +0800, Rob Herring wrote: >> On Thu, Dec 08, 2016 at 05:23:04PM +0800, Yuan Yao wrote: >> > From: Yuan Yao <yao.yuan@xxxxxxx> >> >> Same problem in this subject too. >> >> > >> > new compatible string: "fsl,ls1012a-qspi". >> > >> > Signed-off-by: Yuan Yao <yao.yuan@xxxxxxx> >> > --- >> > Documentation/devicetree/bindings/mtd/fsl-quadspi.txt | 1 + >> > 1 file changed, 1 insertion(+) >> >> Acked-by: Rob Herring <robh@xxxxxxxxxx> > > Thanks for your review. > And do you have any suggestion for this subject? The problem is you have a space in the compatible string: "fsl, ls1012a-qspi" rather than "fsl,ls1012a-qspi" Also, I prefer "dt/bindings: " as the beginning of binding patch subjects. Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
