2016-12-07 15:25 GMT+01:00 Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>: > Hi Bartosz, > > Thank you for the patch. > > On Wednesday 07 Dec 2016 11:42:44 Bartosz Golaszewski wrote: >> Add the vga-bridge node to the board DT together with corresponding >> ports and vga connector. This allows to retrieve the edid info from >> the display automatically. >> >> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx> >> --- >> arch/arm/boot/dts/da850-lcdk.dts | 67 ++++++++++++++++++++++++++++++++++++ >> 1 file changed, 67 insertions(+) >> >> diff --git a/arch/arm/boot/dts/da850-lcdk.dts >> b/arch/arm/boot/dts/da850-lcdk.dts index afcb482..39602eb 100644 >> --- a/arch/arm/boot/dts/da850-lcdk.dts >> +++ b/arch/arm/boot/dts/da850-lcdk.dts >> @@ -51,6 +51,51 @@ >> system-clock-frequency = <24576000>; >> }; >> }; >> + >> + vga-bridge { >> + compatible = "ti,ths8135"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <0>; >> + >> + vga_bridge_in: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&lcdc_out_vga>; >> + }; >> + }; >> + >> + port@1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <1>; >> + >> + vga_bridge_out: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&vga_con_in>; >> + }; >> + }; >> + }; >> + }; >> + >> + vga { >> + compatible = "vga-connector"; >> + >> + ddc-i2c-bus = <&i2c0>; >> + >> + port { >> + vga_con_in: endpoint { >> + remote-endpoint = <&vga_bridge_out>; >> + }; >> + }; >> + }; >> }; >> >> &pmx_core { >> @@ -236,3 +281,25 @@ >> &memctrl { >> status = "okay"; >> }; >> + >> +&lcdc { >> + status = "okay"; >> + pinctrl-names = "default"; >> + pinctrl-0 = <&lcd_pins>; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + lcdc_out: port@1 { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + reg = <1>; >> + >> + lcdc_out_vga: endpoint@0 { >> + reg = <0>; >> + remote-endpoint = <&vga_bridge_in>; >> + }; >> + }; > > Just to make sure you're aware, when there's a single endpoint you can > simplify the DT by omitting the endpoint number. This would become > > lcdc_out: port@1 { > reg = <1>; > > lcdc_out_vga: endpoint { > remote-endpoint = <&vga_bridge_in>; > }; > }; > > It's entirely up to you, both get my > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > >> + }; >> +}; > > -- > Regards, > > Laurent Pinchart > Hi Laurent, thanks for the hint, I'll change it if there's going to be a new version of the series. Best regards, Bartosz Golaszewski -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html