Hi Boris, 2016-11-30 17:17 GMT+09:00 Boris Brezillon <boris.brezillon@xxxxxxxxxxxxxxxxxx>: >> [3] >> Fix raw and oob callbacks. >> >> I asked in another thread, >> the current driver just puts the physically accessed OOB data >> into oob_poi, which is not a collection of ECC data. >> Raw write/read() are wrong as well. > > That's all good things too. > >> >> After fixing those, enable BBT scan by removing the following flag: >> /* skip the scan for now until we have OOB read and write support */ >> chip->options |= NAND_SKIP_BBTSCAN; >> > > Hm, here you have a problem. The layout you described replaces BBMs by > payload data, thus preventing the BBM scan approach (or at least, it > won't work with factory BBMs). As I answered in another mail, the Denali IP expects BBMs at the beginning of each OOB area (standard location). They are protected from the ECC engine. I just did not mention the BBM-reserved area to make the story simpler. So, after fixing oob read/write functions, the driver will be able to enable BBT-scanning. -- Best Regards Masahiro Yamada -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html