2016-11-24 10:19 GMT+08:00 Jun Nie <jun.nie@xxxxxxxxxx>: > 2016-11-18 14:29 GMT+08:00 Jun Nie <jun.nie@xxxxxxxxxx>: >> Add fifo-addr property and fifo-watermark-quirk property to >> synopsys-dw-mshc bindings. It is intended to provide more >> dt interface to support SoCs specific configuration. >> >> Signed-off-by: Jun Nie <jun.nie@xxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 13 +++++++++++++ >> 1 file changed, 13 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt >> index 4e00e85..8bf2e41 100644 >> --- a/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt >> +++ b/Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt >> @@ -76,6 +76,17 @@ Optional properties: >> >> * broken-cd: as documented in mmc core bindings. >> >> +* data-addr: Override fifo address with value provided by DT. The default FIFO reg >> + offset is assumed as 0x100 (version < 0x240A) and 0x200(version >= 0x240A) by >> + driver. If the controller does not follow this rule, please use this property >> + to set fifo address in device tree. >> + >> +* fifo-watermark-aligned: Data done irq is expected if data length is less than >> + watermark in PIO mode. But fifo watermark is requested to be aligned with data >> + length in some SoC so that TX/RX irq can be generated with data done irq. Add this >> + watermark quirk to mark this requirement and force fifo watermark setting >> + accordingly. >> + >> * vmmc-supply: The phandle to the regulator to use for vmmc. If this is >> specified we'll defer probe until we can find this regulator. >> >> @@ -103,6 +114,8 @@ board specific portions as listed below. >> interrupts = <0 75 0>; >> #address-cells = <1>; >> #size-cells = <0>; >> + data-addr = <0x200>; >> + fifo-watermark-aligned; >> }; >> >> [board specific internal DMA resources] >> -- >> 1.9.1 >> > Hi Rob & Mark, > > Could you help review and act this patch if you think it is OK? Thank you! > > Jun Hi Rob & Mark, Could you help comment or act on this patch in revsion 6? Thank you! Jun -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html