On Fri, Nov 25, 2016 at 04:56:53PM +0200, Todor Tomov wrote: > Add DT binding document for Qualcomm Camera subsystem driver. > > Signed-off-by: Todor Tomov <todor.tomov@xxxxxxxxxx> > --- > .../devicetree/bindings/media/qcom,camss.txt | 196 +++++++++++++++++++++ > 1 file changed, 196 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/qcom,camss.txt > > diff --git a/Documentation/devicetree/bindings/media/qcom,camss.txt b/Documentation/devicetree/bindings/media/qcom,camss.txt > new file mode 100644 > index 0000000..76ad89a > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/qcom,camss.txt > @@ -0,0 +1,196 @@ > +Qualcomm Camera Subsystem > + > +* Properties > + > +- compatible: > + Usage: required > + Value type: <stringlist> > + Definition: Should contain: > + - "qcom,8x16-camss" Don't use wildcards in compatible strings. One string per SoC. > +- reg: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: Register ranges as listed in the reg-names property. > +- reg-names: > + Usage: required > + Value type: <stringlist> > + Definition: Should contain the following entries: > + - "csiphy0" > + - "csiphy0_clk_mux" > + - "csiphy1" > + - "csiphy1_clk_mux" > + - "csid0" > + - "csid1" > + - "ispif" > + - "csi_clk_mux" > + - "vfe0" Kind of looks like the phy's should be separate nodes since each phy has its own register range, irq, clocks, etc. > +- interrupts: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: Interrupts as listed in the interrupt-names property. > +- interrupt-names: > + Usage: required > + Value type: <stringlist> > + Definition: Should contain the following entries: > + - "csiphy0" > + - "csiphy1" > + - "csid0" > + - "csid1" > + - "ispif" > + - "vfe0" > +- power-domains: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: A phandle and power domain specifier pairs to the > + power domain which is responsible for collapsing > + and restoring power to the peripheral. > +- clocks: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: A list of phandle and clock specifier pairs as listed > + in clock-names property. > +- clock-names: > + Usage: required > + Value type: <stringlist> > + Definition: Should contain the following entries: > + - "camss_top_ahb_clk" > + - "ispif_ahb_clk" > + - "csiphy0_timer_clk" > + - "csiphy1_timer_clk" > + - "csi0_ahb_clk" > + - "csi0_clk" > + - "csi0_phy_clk" > + - "csi0_pix_clk" > + - "csi0_rdi_clk" > + - "csi1_ahb_clk" > + - "csi1_clk" > + - "csi1_phy_clk" > + - "csi1_pix_clk" > + - "csi1_rdi_clk" > + - "camss_ahb_clk" > + - "camss_vfe_vfe_clk" > + - "camss_csi_vfe_clk" > + - "iface_clk" > + - "bus_clk" > +- vdda-supply: > + Usage: required > + Value type: <phandle> > + Definition: A phandle to voltage supply for CSI2. > +- iommus: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: A list of phandle and IOMMU specifier pairs. > + > +* Nodes > + > +- ports: > + Usage: required > + Definition: As described in video-interfaces.txt in same directory. > + Properties: > + - reg: > + Usage: required > + Value type: <u32> > + Definition: Selects CSI2 PHY interface - PHY0 or PHY1. > + Endpoint node properties: > + - clock-lanes: > + Usage: required > + Value type: <u32> > + Definition: The clock lane. > + - data-lanes: > + Usage: required > + Value type: <prop-encoded-array> > + Definition: An array of data lanes. > + - qcom,settle-cnt: This should go in phy node ideally. > + Usage: required > + Value type: <u32> > + Definition: The settle count parameter for CSI PHY. > + > +* An Example > + > + camss: camss@1b00000 { > + compatible = "qcom,8x16-camss"; > + reg = <0x1b0ac00 0x200>, > + <0x1b00030 0x4>, > + <0x1b0b000 0x200>, > + <0x1b00038 0x4>, > + <0x1b08000 0x100>, > + <0x1b08400 0x100>, > + <0x1b0a000 0x500>, > + <0x1b00020 0x10>, > + <0x1b10000 0x1000>; > + reg-names = "csiphy0", > + "csiphy0_clk_mux", > + "csiphy1", > + "csiphy1_clk_mux", > + "csid0", > + "csid1", > + "ispif", > + "csi_clk_mux", > + "vfe0"; > + interrupts = <GIC_SPI 78 0>, > + <GIC_SPI 79 0>, > + <GIC_SPI 51 0>, > + <GIC_SPI 52 0>, > + <GIC_SPI 55 0>, > + <GIC_SPI 57 0>; > + interrupt-names = "csiphy0", > + "csiphy1", > + "csid0", > + "csid1", > + "ispif", > + "vfe0"; > + power-domains = <&gcc VFE_GDSC>; > + clocks = <&gcc GCC_CAMSS_TOP_AHB_CLK>, > + <&gcc GCC_CAMSS_ISPIF_AHB_CLK>, > + <&gcc GCC_CAMSS_CSI0PHYTIMER_CLK>, > + <&gcc GCC_CAMSS_CSI1PHYTIMER_CLK>, > + <&gcc GCC_CAMSS_CSI0_AHB_CLK>, > + <&gcc GCC_CAMSS_CSI0_CLK>, > + <&gcc GCC_CAMSS_CSI0PHY_CLK>, > + <&gcc GCC_CAMSS_CSI0PIX_CLK>, > + <&gcc GCC_CAMSS_CSI0RDI_CLK>, > + <&gcc GCC_CAMSS_CSI1_AHB_CLK>, > + <&gcc GCC_CAMSS_CSI1_CLK>, > + <&gcc GCC_CAMSS_CSI1PHY_CLK>, > + <&gcc GCC_CAMSS_CSI1PIX_CLK>, > + <&gcc GCC_CAMSS_CSI1RDI_CLK>, > + <&gcc GCC_CAMSS_AHB_CLK>, > + <&gcc GCC_CAMSS_VFE0_CLK>, > + <&gcc GCC_CAMSS_CSI_VFE0_CLK>, > + <&gcc GCC_CAMSS_VFE_AHB_CLK>, > + <&gcc GCC_CAMSS_VFE_AXI_CLK>; > + clock-names = "camss_top_ahb_clk", > + "ispif_ahb_clk", > + "csiphy0_timer_clk", > + "csiphy1_timer_clk", > + "csi0_ahb_clk", > + "csi0_clk", > + "csi0_phy_clk", > + "csi0_pix_clk", > + "csi0_rdi_clk", > + "csi1_ahb_clk", > + "csi1_clk", > + "csi1_phy_clk", > + "csi1_pix_clk", > + "csi1_rdi_clk", > + "camss_ahb_clk", > + "camss_vfe_vfe_clk", > + "camss_csi_vfe_clk", > + "iface_clk", > + "bus_clk"; > + vdda-supply = <&pm8916_l2>; > + iommus = <&apps_iommu 3>; > + ports { > + #address-cells = <1>; > + #size-cells = <0>; > + port@0 { > + reg = <0>; > + csiphy0_ep: endpoint { > + clock-lanes = <1>; > + data-lanes = <0 2>; > + qcom,settle-cnt = <0xe>; > + remote-endpoint = <&ov5645_ep>; > + }; > + }; > + }; > + }; > -- > 1.9.1 > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html