Am Freitag, den 25.11.2016, 11:04 +0800 schrieb zhangfei: > > On 2016年11月24日 17:26, Philipp Zabel wrote: > > Am Mittwoch, den 23.11.2016, 16:07 +0800 schrieb Zhangfei Gao: > >> Add DT bindings documentation for hi3660 SoC reset controller. > >> > >> Signed-off-by: Zhangfei Gao <zhangfei.gao@xxxxxxxxxx> > >> --- > >> .../bindings/reset/hisilicon,hi3660-reset.txt | 51 ++++++++++++++++++++++ > >> 1 file changed, 51 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt > >> > >> diff --git a/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt > >> new file mode 100644 > >> index 0000000..250daf2 > >> --- /dev/null > >> +++ b/Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.txt > >> @@ -0,0 +1,51 @@ > >> +Hisilicon System Reset Controller > >> +====================================== > >> + > >> +Please also refer to reset.txt in this directory for common reset > >> +controller binding usage. > >> + > >> +The reset controller registers are part of the system-ctl block on > >> +hi3660 SoC. > >> + > >> +Required properties: > >> +- compatible: should be > >> + "hisilicon,hi3660-reset" > >> +- #reset-cells: 1, see below > >> +- hisi,rst-syscon: phandle of the reset's syscon. > >> +- hisi,reset-bits: Contains the reset control register information > >> + Should contain 2 cells for each reset exposed to > >> + consumers, defined as: > >> + Cell #1 : offset from the syscon register base > >> + Cell #2 : bits position of the control register > >> + > >> +Example: > >> + iomcu: iomcu@ffd7e000 { > >> + compatible = "hisilicon,hi3660-iomcu", "syscon"; > >> + reg = <0x0 0xffd7e000 0x0 0x1000>; > >> + }; > >> + > >> + iomcu_rst: iomcu_rst_controller { > > This should be > > iomcu_rst: reset-controller { > By the way, could I keep the original name? > Since there will be build error if several nodes use the same name. > like: > - iomcu_rst: iomcu_rst_controller { > + iomcu_rst: reset-controller { > > - crg_rst: crg_rst_controller { > + crg_rst: reset-controller { That should not be a problem if they are moved inside the controlling node: iomcu { iomcu_rst: reset-controller { }; }; crg { crg_rst: reset-controller { }; }; regards Philipp -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html