On Wed 16 Nov 06:02 PST 2016, Avaneesh Kumar Dwivedi wrote: > > > On 11/11/2016 2:00 AM, Rob Herring wrote: > >On Fri, Nov 04, 2016 at 07:30:54PM +0530, Avaneesh Kumar Dwivedi wrote: > >>Encapsulate resources specific to each version of hexagon chip to > >>device node to avoid conditional check for manipulation of those > >>resources in driver code. > >> > >>Signed-off-by: Avaneesh Kumar Dwivedi <akdwived@xxxxxxxxxxxxxx> > >>--- > >> .../devicetree/bindings/remoteproc/qcom,q6v5.txt | 1 + > >> drivers/remoteproc/qcom_q6v5_pil.c | 137 ++++++++++++++++++--- > >> 2 files changed, 120 insertions(+), 18 deletions(-) > >> > >>diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > >>index 57cb49e..cbc165c 100644 > >>--- a/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > >>+++ b/Documentation/devicetree/bindings/remoteproc/qcom,q6v5.txt > >>@@ -8,6 +8,7 @@ on the Qualcomm Hexagon core. > >> Value type: <string> > >> Definition: must be one of: > >> "qcom,q6v5-pil" > >>+ "qcom,q6v56-pil" > >Perhaps some explanation in the commit message about what these magic > >numbers mean? > > "v56" represent class of hexagon chip, which again is differentiated > based on version number. Two > different MSM SOC may use same class of hexagon chip. example is as > below. > > msm8974 q6v5 version 5.0.0 > msm8916 q6v5 version 5.1.1 But looking at the Qualcomm tree I think I got 8916 wrong, it seems that it should be "q6v56" and your patches indicates that the 8996 has a q6v55 - which doesn't make sense to me and in some places there's comments indicating it's version 6. I asked you about this but I can't find an answer in any of your replies. Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
