Rob, Hans, Pantelis, On 11/14/16 17:56, Frank Rowand wrote: > On 11/14/16 14:16, Rob Herring wrote: >> On Mon, Nov 14, 2016 at 12:44 PM, Frank Rowand <frowand.list@xxxxxxxxx> wrote: < snip > >> >> These helpers are useful and easier to use than the existing API >> independent of any issues to sort out with how we use overlays. So I >> plan to take them whether there's a user right away or not. >> >> Rob > > OK, expect a more detailed review from me this week. > > -Frank Part of my issues with these patches is related to using a format string and the variables required by that format string as arguments to several of the proposed helper functions. That construct is driven by the helper functions calling __of_node_dup() which has that same pattern of arguments. Blindly accepting a format string as an argument to populate a buffer is not good from a security or robustness standpoint. The only callers of __of_node_dup() are one site in drivers/of/overlay.c and three sites in drivers/of/unittest.c. I would like to see if I can find a good alternate to the format string approach in __of_node_dup(), which would remove that issue in the helper functions. I do not expect Hans to fix the existing __of_node_dup(), I am willing to do that myself. Rob, are you in a hurry to accept the helper functions or are you willing to give me some time to resolve the __of_node_dup() issue and come up with a new version of the helper function patches? Caveat, I have a hard deadline late Monday Nov 21 so I can't start on this until Nov 22. Then that is Thanksgiving week and I have some other work commitments that will demand much of my time the next two weeks. I can commit to starting Nov 22, then making it my top priority starting Dec 12. -Frank -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
