Re: [PATCH v4 3/6] ARM: at91/dt: define sama5d3 clocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hello Arnd,

On 09/12/2013 03:09, Arnd Bergmann wrote:
On Thursday 28 November 2013, Boris BREZILLON wrote:
@@ -92,6 +103,8 @@
  				dma-names = "tx", "rx";
  				pinctrl-names = "default";
  				pinctrl-0 = <&pinctrl_spi0>;
+				clocks = <&spi0_clk>;
+				clock-names = "spi_clk";
  				status = "disabled";
  			};
@@ -101,6 +114,8 @@
  				interrupts = <38 IRQ_TYPE_LEVEL_HIGH 4>;
  				pinctrl-names = "default";
  				pinctrl-0 = <&pinctrl_ssc0_tx &pinctrl_ssc0_rx>;
+				clocks = <&ssc0_clk>;
+				clock-names = "pclk";
  				status = "disabled";
  			};
You are adding "clock-names" properties in a lot of cases. Are you sure you
are using the strings that are documented in the respective device bindings
for each name? In a lot of cases, drivers just want an anonymous clock
and we don't name them.

I rechecked it, and almost all drivers call [devm_]clk_get with a specific clock
name, and as a result we must specify the "clock-names" property.
The only exceptions I found are the spi and PIT (Periodic Interval Timer) drivers,
and "clock-names" property is not defined in these nodes.


Best Regards,

Boris

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux