Hi Shawn, On Tue, Nov 1, 2016 at 3:13 PM, Shawn Guo <shawnguo@xxxxxxxxxx> wrote: > On Tue, Oct 25, 2016 at 11:19:51PM +0200, Gary Bisson wrote: >> SoM based on i.MX6 Quad with 1GB of DDR3. >> >> https://boundarydevices.com/product/nit6x-som-v2/ >> >> Signed-off-by: Gary Bisson <gary.bisson@xxxxxxxxxxxxxxxxxxx> >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/imx6q-nitrogen6_som2.dts | 53 ++ >> arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi | 770 ++++++++++++++++++++++++++ >> 3 files changed, 824 insertions(+) >> create mode 100644 arch/arm/boot/dts/imx6q-nitrogen6_som2.dts >> create mode 100644 arch/arm/boot/dts/imx6qdl-nitrogen6_som2.dtsi > > <snip> > >> +/ { >> + chosen { >> + stdout-path = &uart2; >> + }; >> + >> + memory { >> + reg = <0x10000000 0x40000000>; >> + }; >> + >> + backlight_lcd: backlight_lcd { > > Please use hyphen instead of underscore in node name. Please check > through the patch series. Sorry about that, forgot (again). Just to make sure, the label can have underscore but not the name right? Or is it better to have hypens everywhere? So I guess I need to make a pass on current boards as well. Some patches in my series rename the panel to panel_lvdsX to match the current Nitrogen6_MAX naming[1] but this would need to be changed to panel-lvdsX as well. Regards, Gary [1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/imx6qdl-nitrogen6_max.dtsi#n296 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html