On 10/31/2016 11:20 AM, Joachim Eastwood wrote: > Hi Neil, > > On 31 October 2016 at 10:55, Neil Armstrong <narmstrong@xxxxxxxxxxxx> wrote: >> On 10/30/2016 09:41 PM, Rob Herring wrote: >>> On Fri, Oct 21, 2016 at 10:44:45AM +0200, Neil Armstrong wrote: >>>> Add Synopsys Designware MAC Glue layer for the Oxford Semiconductor OX820. >>>> >>>> Signed-off-by: Neil Armstrong <narmstrong@xxxxxxxxxxxx> >>>> --- >>>> .../devicetree/bindings/net/oxnas-dwmac.txt | 44 +++++ >>> >>> It's preferred that bindings are a separate patch. >> >> OK >> >>> >>>> drivers/net/ethernet/stmicro/stmmac/Kconfig | 11 ++ >>>> drivers/net/ethernet/stmicro/stmmac/Makefile | 1 + >>>> drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c | 219 +++++++++++++++++++++ >>>> 4 files changed, 275 insertions(+) >>>> create mode 100644 Documentation/devicetree/bindings/net/oxnas-dwmac.txt >>>> create mode 100644 drivers/net/ethernet/stmicro/stmmac/dwmac-oxnas.c >>>> >>>> Changes since RFC at https://patchwork.kernel.org/patch/9387257 : >>>> - Drop init/exit callbacks >>>> - Implement proper remove and PM callback >>>> - Call init from probe >>>> - Disable/Unprepare clock if stmmac probe fails >>>> >>>> diff --git a/Documentation/devicetree/bindings/net/oxnas-dwmac.txt b/Documentation/devicetree/bindings/net/oxnas-dwmac.txt >>>> new file mode 100644 >>>> index 0000000..5d2696c >>>> --- /dev/null >>>> +++ b/Documentation/devicetree/bindings/net/oxnas-dwmac.txt >>>> @@ -0,0 +1,44 @@ >>>> +* Oxford Semiconductor OXNAS DWMAC Ethernet controller >>>> + >>>> +The device inherits all the properties of the dwmac/stmmac devices >>>> +described in the file stmmac.txt in the current directory with the >>>> +following changes. >>>> + >>>> +Required properties on all platforms: >>>> + >>>> +- compatible: Depending on the platform this should be one of: >>>> + - "oxsemi,ox820-dwmac" >>>> + Additionally "snps,dwmac" and any applicable more >>>> + detailed version number described in net/stmmac.txt >>>> + should be used. >>> >>> You should be explicit what version applies to ox820. "snps,dwmac" >>> should probably be deprecated IMO. There are so many variations of DW >>> h/w. >> >> Well, to be honest I have absolutely no idea ! But I will try to find out... > > You can see in the boot log: > > From lpc18xx boot: > [ 3.242253] stmmac - user ID: 0x11, Synopsys ID: 0x36 > [ 3.247653] Ring mode enabled > [ 3.251491] DMA HW capability register supported > [ 3.256336] Enhanced/Alternate descriptors > [ 3.261537] Enabled extended descriptors > [ 3.265968] RX Checksum Offload Engine supported (type 2) > [ 3.272249] TX Checksum insertion supported > [ 3.276874] Wake-Up On Lan supported > [ 3.283743] Enable RX Mitigation via HW Watchdog Timer > [ 3.326701] libphy: stmmac: probed > > Synopsys ID: 0x36 and user UD: 0x11, gives us DWMAC version 3.611 > > > regards, > Joachim Eastwood > OK, thanks ! stmmac - user ID: 0x12, Synopsys ID: 0x35 Neil -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
