On Mon, Oct 24, 2016 at 6:51 AM, Andrey Smirnov <andrew.smirnov@xxxxxxxxx> wrote: > It seem strange to me that the driver uses "handle_edge_irq", given > how none of the individual interrupts seem to require any ACKing, > since it is all handled in sx150x_irq_thread_fn(), line 533. More so, > I had trouble finding who/where sets .irq_ack() callback, which AFAIU > is mandatory for handle_edge_irq(). Yes that looks strange. Neil have you tested IRQs with this code? If there is trouble, please follow up with a fix for the edge handler. Maybe it should just be handle_simple_irq(). Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html