Re: [PATCH v2] DT: ATA: Add missing documentation of clocks to marvell binding.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Thu, Dec 05, 2013 at 03:50:19PM +0000, Andrew Lunn wrote:
> The marvell SATA driver can optionally make use of clocks specified in
> the DT node. This has been available in the driver since Febuary 2012,
> but the documentation is missing from the binding. Add it.
> 
> Signed-off-by: Andrew Lunn <andrew@xxxxxxx>
> ---
> FYI: This will cause merge conflicts with the SATA PHY driver comming soon.
> 
> v1->v2:
> s/pHandle/phandle/
> Add specifier.
> 
> Not addressed yet is changing "0" to "port0", etc. Waiting for feedback
> from Mark Rutland.

I'm happy with the clock-names as they are, thanks for applying the
other changes.

Thanks for fixing up the documentation!

Acked-by: Mark Rutland <mark.rutland@xxxxxxx>

> ---
>  Documentation/devicetree/bindings/ata/marvell.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/ata/marvell.txt b/Documentation/devicetree/bindings/ata/marvell.txt
> index b5cdd20cde9c..acfdb439bb6c 100644
> --- a/Documentation/devicetree/bindings/ata/marvell.txt
> +++ b/Documentation/devicetree/bindings/ata/marvell.txt
> @@ -6,11 +6,17 @@ Required Properties:
>  - interrupts    : Interrupt controller is using
>  - nr-ports      : Number of SATA ports in use.
>  
> +Optional Properties:
> +- clocks        : List of phandle and specifier to clocks
> +- clock-names   : Must be "0", "1", mapping port number to clock.
> +
>  Example:
>  
>  	sata@80000 {
>  		compatible = "marvell,orion-sata";
>  		reg = <0x80000 0x5000>;
>  		interrupts = <21>;
> +		clocks = <&gate_clk 14>, <&gate_clk 15>;
> +		clock-names = "0", "1";
>  		nr-ports = <2>;
>  	}
> -- 
> 1.8.5
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux