> On Oct 10, 2016, at 23:29 , Rob Herring <robh@xxxxxxxxxx> wrote: > > On Fri, Oct 07, 2016 at 06:21:09PM +0300, Pantelis Antoniou wrote: >> From: Georgi Vlaev <gvlaev@xxxxxxxxxxx> >> >> Adds the I2CS Fan Tray hwmon device tree node documentation. >> >> Signed-off-by: Georgi Vlaev <gvlaev@xxxxxxxxxxx> >> [Ported from Juniper kernel] >> Signed-off-by: Pantelis Antoniou <pantelis.antoniou@xxxxxxxxxxxx> >> --- >> Documentation/devicetree/bindings/hwmon/i2cs-fan.txt | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/i2cs-fan.txt >> >> diff --git a/Documentation/devicetree/bindings/hwmon/i2cs-fan.txt b/Documentation/devicetree/bindings/hwmon/i2cs-fan.txt >> new file mode 100644 >> index 0000000..4ef880c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/hwmon/i2cs-fan.txt >> @@ -0,0 +1,19 @@ >> +Hwmon driver for Juniper fan trays on I2CS Slave FPGA > > This is a h/w description, not a driver. > >> + >> +Required properties: >> + >> +- compatible: "i2cs-fan-hwmon" > > I doubt any fan control h/w has "hwmon" in the name. > >> + >> +Optional properties: >> + >> +- num-fans: fans per tray (default 14) >> + >> +- tach-factor: TACH count scaling factor (default 120) > > vendor prefixes needed. > >> + >> +Example: >> + >> +fan-hwmon { >> + compatible = "jnx,i2cs-fan-hwmon"; >> + num-fans = <6>; >> + tach-factor = <33>; >> +}; >> -- >> 1.9.1 OK on all three.-- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html