Re: [PATCH 1/2] regulator: gpio-regulator: Add required regulator-type property

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Mark,

On Thursday 05 December 2013 00:09:28 Mark Brown wrote:
> On Thu, Nov 28, 2013 at 04:44:52PM +0100, Laurent Pinchart wrote:
> > The gpio-regulator driver requires the regulator-type property to be
> > present. Document it as required in the DT bindings.
> 
> It does?  That seems needless.  It should just default to voltage and
> provide a way override to current, though frankly I'd be astonished to see a
> GPIO controlled current regulator at all so I'm not sure I'd even bother
> writing the code for that until someone needs it.  As it is this will most
> likely just be noise in the DT files and wasted cycles parsing the property.

I'm fine with that. The property should still be documented in the DT bindings 
as optional though. Or be removed completely until a GPIO-controlled current 
regulator is needed.

> Please CC maintainers...

My bad, sorry.

-- 
Regards,

Laurent Pinchart

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux