On Wed, Dec 04, 2013 at 03:19:27PM -0700, Stephen Warren wrote:
> From: Stephen Warren <swarren@xxxxxxxxxx>
>
> Initially, this binding and driver only describe/support playback to
> headphones and speakers, and capture from the external microphone, with
> GPIO-based jack detection for the headphone jack only.
Looks good. I don't see patch 1, I take it that's the DT or something
and there's no dependency for merging and I can apply? The DT binding
is a common pattern so I'm OK with that not getting separate review.
> + switch (srate) {
> + case 8000:
> + case 16000:
> + case 24000:
> + case 32000:
> + case 48000:
> + case 64000:
> + case 96000:
> + mclk = 12288000;
> + break;
> + case 11025:
> + case 22050:
> + case 44100:
> + case 88200:
> + mclk = 11289600;
> + break;
> + default:
> + mclk = 12000000;
> + break;
> + }
Not a problem here but this is a really common pattern in one form or
another, we should probably have a helper for it. Might help with the
generic card work.
Attachment:
signature.asc
Description: Digital signature
