* Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> [131204 10:45]: > On Wednesday 04 December 2013 10:24:37 Tony Lindgren wrote: > > > > OK. I wonder if we should add something like this to make it easier to > > use the padconf values from the TRM: > > > > #define OMAP_IOPAD_OFFSET(pa, offset) ((pa) & 0xffff) - (offset)) > > > > #define OMAP2_CORE_IOPAD(pa, val) (OMAP_IOPAD_OFFSET((pa), 0x0030) (val)) > > #define OMAP3_CORE1_IOPAD(pa, val) OMAP2_CORE_IOPAD((pa), (val)) > > #define OMAP3_CORE2_IOPAD(pa, val) (OMAP_IOPAD_OFFSET((pa), 0x05a0) (val)) > > #define OMAP4_CORE_IOPAD(pa, val) (OMAP_IOPAD_OFFSET((pa), 0x0040) (val)) > > #define OMAP4_WKUP_IOPAD(pa, val) (OMAP_IOPAD_OFFSET((pa), 0xe040) (val)) > > #define OMAP5_CORE_IOPAD(pa, val) (OMAP_IOPAD_OFFSET((pa), 0x0840) (val)) > > #define OMAP5_WKUP_IOPAD(pa, val) (OMAP_IOPAD_OFFSET((pa), 0xc850) (val)) > > ... > > > > Then we would have entries like: > > > > pinctrl-single,pins = < > > OMAP3_CORE1_IOPAD(0x158, PIN_INPUT_PULLUP | MUX_MODE0) > > ... > > >; > > > > instead of: > > > > pinctrl-single,pins = < > > 0x128 (PIN_INPUT_PULLUP | MUX_MODE0) > > ... > > >; > > That's a good idea, it would be much more readable. Would you like to submit a > patch ? Should I rebase my patch on top of that, or the other way around ? OK I'll do a patch for that later on today, then you can use that. Might cut down the churn a little that way. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
