> > > +MAXIM MAX14577 multi-function device > > > > Why is Maxim capitalised in such a way? > > > > If you're going to use the term Multi-Function Device, please > > capitalise it. > > > > > +MAX14577 is a Multi-function device with Micro-USB Interface Circuit, Li+ > > > > Same here. > > I'll fix this. The MAXIM capitalization came from other drivers. No need to repeat mistakes. I believe it should be Maxim. > > > +Example: > > > + max14577@25 { > > > + compatible = "maxim,max14577"; > > > + reg = <0x25>; > > > + interrupt-parent = <&gpx1>; > > > + interrupts = <5 0>; > > > > I'm gussing this is IRQ5 and the 0 is flags? If so, please use > > #defines for the flags. > > This is a standard interrupt binding. The max14577 MFD core driver > ignores the interrupt flags and always uses IRQF_TRIGGER_FALLING. I can > fix this with new patch for drivers/mfd/max14577.c but still I don't see > what should be added in documentation. s/0/IRQ_TYPE_NONE -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html