On 09/28/2016 03:53 PM, Corey Minyard wrote: > On 09/26/2016 01:50 AM, Cédric Le Goater wrote: >> >>>> Changes since v1: >>>> >>>> - replace 'bt_host' by 'bt_bmc' to reflect that the driver is >>>> the BMC side of the IPMI BT interface >>>> - renamed the device to 'ipmi-bt-host' >>>> - introduced a temporary buffer to copy_{to,from}_user >>>> - used platform_get_irq() >>>> - moved the driver under drivers/char/ipmi/ but kept it as a misc >>>> device >>>> - changed the compatible cell to "aspeed,ast2400-bt-bmc" >>>> >>>> .../bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt | 23 + >>> While similar, this is not the kernel directory structure. Just make >>> this bindings/ipmi/ >>> >>> With that, >>> >>> Acked-by: Rob Herring <robh@xxxxxxxxxx> >> OK. So I suppose we should be moving all IPMI documentation under >> the same directory. >> >> >> Corey, >> >> If the move is okay for you, I can send the patch below. >> >> Thanks, >> >> C. > > Sorry this took so long, I'm at a conference. That change is fine, it does > seem to match the structure better. It's ok. Checkpatch really does not like that patch and I don't know what we can do about it. You've been warned :) Thanks, C. ./scripts/checkpatch.pl --strict 0001-dt-bindings-ipmi-move-all-documentation-under-bindin.patch WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #12: .../devicetree/bindings/{char => }/ipmi/aspeed,ast2400-bt-bmc.txt | 0 ERROR: Does not appear to be a unified-diff format patch total: 1 errors, 1 warnings, 0 checks, 0 lines checked -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html