Re: [PATCH v3 1/3] ipmi: add an Aspeed BT IPMI BMC driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 09/26/2016 01:50 AM, Cédric Le Goater wrote:

  Changes since v1:

  - replace 'bt_host' by 'bt_bmc' to reflect that the driver is
    the BMC side of the IPMI BT interface
  - renamed the device to 'ipmi-bt-host'
  - introduced a temporary buffer to copy_{to,from}_user
  - used platform_get_irq()
  - moved the driver under drivers/char/ipmi/ but kept it as a misc
    device
  - changed the compatible cell to "aspeed,ast2400-bt-bmc"

  .../bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt   |  23 +
While similar, this is not the kernel directory structure. Just make
this bindings/ipmi/

With that,

Acked-by: Rob Herring <robh@xxxxxxxxxx>
OK. So I suppose we should be moving all IPMI documentation under
the same directory.


Corey,

If the move is okay for you, I can send the patch below.

Thanks,

C.

Sorry this took so long, I'm at a conference.  That change is fine, it does
seem to match the structure better.

-corey

 From ca25f89b25209c260480cda5e5532d6bbe83ed43 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <clg@xxxxxxxx>
Date: Mon, 26 Sep 2016 08:45:15 +0200
Subject: [PATCH] dt-bindings: ipmi: move all documentation under
  bindings/ipmi/
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Cédric Le Goater <clg@xxxxxxxx>
---
  .../devicetree/bindings/{char => }/ipmi/aspeed,ast2400-bt-bmc.txt         | 0
  Documentation/devicetree/bindings/{ipmi.txt => ipmi/ipmi-smic.txt}        | 0
  2 files changed, 0 insertions(+), 0 deletions(-)
  rename Documentation/devicetree/bindings/{char => }/ipmi/aspeed,ast2400-bt-bmc.txt (100%)
  rename Documentation/devicetree/bindings/{ipmi.txt => ipmi/ipmi-smic.txt} (100%)

diff --git a/Documentation/devicetree/bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt b/Documentation/devicetree/bindings/ipmi/aspeed,ast2400-bt-bmc.txt
similarity index 100%
rename from Documentation/devicetree/bindings/char/ipmi/aspeed,ast2400-bt-bmc.txt
rename to Documentation/devicetree/bindings/ipmi/aspeed,ast2400-bt-bmc.txt
diff --git a/Documentation/devicetree/bindings/ipmi.txt b/Documentation/devicetree/bindings/ipmi/ipmi-smic.txt
similarity index 100%
rename from Documentation/devicetree/bindings/ipmi.txt
rename to Documentation/devicetree/bindings/ipmi/ipmi-smic.txt


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux