On 2016/9/20 22:43, Rob Herring wrote: > On Mon, Sep 12, 2016 at 09:51:46AM +0800, Jian Yuan wrote: >> From: yuanjian <yuanjian12@xxxxxxxxxxxxx> >> >> Add PWM driver for the PWM controller found on HiSilicon BVT SOCs, like Hi3519V100, Hi3516CV300, etc. >> The PWM controller is primarily in charge of controlling P-Iris lens. >> >> Reviewed-by: Jiancheng Xue <xuejiancheng@xxxxxxxxxxxxx> >> Signed-off-by: Jian Yuan <yuanjian12@xxxxxxxxxxxxx> >> --- >> Change Log: >> v3: >> Add PWM compatible string for Hi3519V100. >> Implement .apply() function which support atomic, instead of .enable()/.disable()/.config(). >> v2: >> The number of PWMs is change to be probeable based on the compatible string. >> >> .../devicetree/bindings/pwm/pwm-hibvt.txt | 20 ++ >> drivers/pwm/Kconfig | 9 + >> drivers/pwm/Makefile | 1 + >> drivers/pwm/pwm-hibvt.c | 270 +++++++++++++++++++++ >> 4 files changed, 300 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> create mode 100644 drivers/pwm/pwm-hibvt.c >> >> diff --git a/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt b/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> new file mode 100644 >> index 0000000..2ecf4e4 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/pwm/pwm-hibvt.txt >> @@ -0,0 +1,20 @@ >> +Hisilicon PWM controller >> + >> +Required properties: >> +-compatible: should contain one SoC specific compatible string and one generic compatible >> +string "hisilicon, hibvt-pwm". The SoC specific strings supported including: >> + "hisilicon,hi3516cv300-pwm" >> + "hisilicon,hi3519v100-pwm" >> +- reg: physical base address and length of the controller's registers. >> +- clocks: phandle and clock specifier of the PWM reference clock. >> +- resets: phandle and reset specifier for the PWM controller reset. > > You are missing #pwm-cells. > Ok, thanks. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
