Hello Randy, On 09/16/2016 01:21 PM, Krzysztof Kozlowski wrote: [snip] >>>> + >>>> + beep { >>>> + compatible = "pwm-beeper"; >>>> + pwms = <&pwm 0 4000000 PWM_POLARITY_INVERTED>; >>> I have serious doubts that you run this code... if it does not even >>> compile. Sorry, I cannot accept code that does not compile and was not >>> tested. >>> >>> Please, test your DTS on top of current Linux tree, which would be one of: >>> 1. Linus' master branch: v4.8-rc6, >>> 2. one of my branches (for-next, next/dt etc), >> When I sent those patches, I tested in "Add linux-next specific files for >> 20160907" > > OK, good, but please tell me why kbuild reported that build error? > I agree with Krzysztof, it doesn't seem that you tested the exact version that was posted. You will need the following change to make the DTS build in latest linux-next: diff --git a/arch/arm/boot/dts/exynos4412-itop-elite.dts b/arch/arm/boot/dts/exynos4412-itop-elite.dts index dd83689892ff..8559f891a740 100644 --- a/arch/arm/boot/dts/exynos4412-itop-elite.dts +++ b/arch/arm/boot/dts/exynos4412-itop-elite.dts @@ -14,6 +14,7 @@ */ /dts-v1/; +#include <dt-bindings/pwm/pwm.h> #include <dt-bindings/sound/samsung-i2s.h> #include "exynos4412-itop-scp-core.dtsi" So please squash that change and resend. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html