Re: [PATCH RESEND v5 1/2] PWM: PXA: add device tree support to PWM driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 12/04/2013 02:45 AM, Mike Dunn wrote:
On 12/03/2013 02:17 AM, Thierry Reding wrote:
On Sat, Sep 21, 2013 at 12:19:33PM -0700, Mike Dunn wrote:
This patch adds device tree support to the PXA's PWM driver.  Nothing
needs to be extracted from the device tree node by the PWM device.
Client devices need only specify the period; the per-chip index is
implicitly zero because one device node must be present for each PWM
output in use.  This approach is more convenient due to the wide
variability in the number of PWM channels present across the various PXA
variants, and is made possible by the fact that the register sets for
each PWM channel are segregated from each other.  An of_xlate() method
is added to parse this single-cell node.  The existing ID table is
reused for the match table data.

Tested on a Palm Treo 680 (both platform data and DT cases).

Signed-off-by: Mike Dunn <mikedunn@xxxxxxxxxxx>
---
  Documentation/devicetree/bindings/pwm/pxa-pwm.txt | 30 +++++++++++++
  drivers/pwm/pwm-pxa.c                             | 52 ++++++++++++++++++++++-
  2 files changed, 81 insertions(+), 1 deletion(-)
  create mode 100644 Documentation/devicetree/bindings/pwm/pxa-pwm.txt
Hi Mike,

It looks like this fell through the cracks. Is this patch still the
latest one you have? Should it still be applied?

Thierry

Hi Thierry,

Funny I should hear from you about this today.... I just turned my attention
back to this today and noticed that it never made it into your for-next branch.
  Yes, it is the latest.  If the patch still applies cleanly, please feel free.
Otherwise, I'd be glad to rework it against something more recent.

Also, we never got any ACKs for patch 2/2, which just adds the nodes to
arch/arm/boot/dts/pxa27x.dtsi
Any advice on whom to nudge?

Thanks much!
Mike


It's fine to me.

Acked-by: Haojian Zhuang <haojian.zhuang@xxxxxxxxxx>

Regards
Haojian
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux