Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> writes: > From: Jerome Brunet <jbrunet@xxxxxxxxxxxx> > > Enable both gxbb USB controller and add a 5V regulator for the OTG port > VBUS > > Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> nit: subject should have "ARM64: dts:" prefix. > --- > arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi | 29 ++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi > index ce105fe..4493bce 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb-p20x.dtsi > @@ -93,6 +93,18 @@ > compatible = "mmc-pwrseq-emmc"; > reset-gpios = <&gpio BOOT_9 GPIO_ACTIVE_LOW>; > }; > + > + usb_vbus: regulator-usb0-vbus { nit: I like to use the signal name from the schematics for the node name (and for regulator-name below). In the schematics, that signal is named USB_PWR. > + compatible = "regulator-fixed"; > + > + regulator-name = "USB0_VBUS"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + > + gpio = <&gpio GPIODV_24 GPIO_ACTIVE_HIGH>; Please add a comment above this line with the schematic signal name: USB_PWR_EN. > + enable-active-high; > + }; > }; Kevin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html