Re: [RFC PATCH v3 3/8] regulator: add pbias regulator support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, Dec 03, 2013 at 09:24:15PM +0530, Balaji T K wrote:
> On Thursday 21 November 2013 08:16 PM, Mark Brown wrote:

> >These don't match up with each other - the get and set voltage calls
> >should reflect what the hardware state is, not what was requested by the
> >caller.  You should be able to use the regmap helpers I think.

> get_voltage returns the min_uV, saved in set_voltage since pbias
> only need to programmed if the voltage supply in for pbias cell is less than
> or greater than 1.8V, so vmode bit will be set for 3V and also for 3.3V too.

That's the problem...

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux