On Monday 02 of December 2013 10:50:14 Olof Johansson wrote: > Hi, > > On Wed, Nov 27, 2013 at 8:34 PM, Leela Krishna Amudala > <l.krishna@xxxxxxxxxxx> wrote: > > This patch adds pmusysreg node to exynos5250 and exynos5420 dtsi files to > > handle PMU register accesses in a centralized way using syscon driver > > > > Signed-off-by: Leela Krishna Amudala <l.krishna@xxxxxxxxxxx> > > Reviewed-by: Tomasz Figa <t.figa@xxxxxxxxxxx> > > Reviewed-by: Doug Anderson <dianders@xxxxxxxxxxxx> > > Tested-by: Doug Anderson <dianders@xxxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/arm/samsung/pmu.txt | 16 ++++++++++++++++ > > arch/arm/boot/dts/exynos5250.dtsi | 5 +++++ > > arch/arm/boot/dts/exynos5420.dtsi | 5 +++++ > > 3 files changed, 26 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/arm/samsung/pmu.txt > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.txt b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > > new file mode 100644 > > index 0000000..307e727 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.txt > > @@ -0,0 +1,16 @@ > > +SAMSUNG Exynos SoC series PMU Registers > > + > > +Properties: > > + - name : should be 'syscon'; > > It's common to use a non-abbreviated name, such as 'system-controller' > here. Or, given that it's referring to "pmusysreg" then maybe > something like "pmu-system-registers". Hmm, it's two syscons vs two system-controllers in existing device trees. I agree that system-controller sounds much better as a name for this class of devices. I don't remember why I initially suggested syscon, though. Possibly based on those two existing device trees using this name. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html