Hi Javier,
On 2016년 08월 27일 02:49, Javier Martinez Canillas wrote:
> Hello Chanwoo,
>
> The patch looks good to me, I just have a few minor comments:
>
> On 08/24/2016 09:49 AM, Chanwoo Choi wrote:
>
> [snip]
>
>> +
>> + reboot: syscon-reboot {
>> + compatible = "syscon-reboot";
>> + regmap = <&pmu_system_controller>;
>> + offset = <0x400>;
>
> Maybe adding a comment that the register is SWRESET to be consistent with the
> arm32 Exynos node definition in arch/arm/boot/dts/exynos-syscon-restart.dtsi?
OK. I'll add a comment as following:
offset = <0x400>; /* SWRESET */
>
> [snip]
>
>> +
>> + tmu_atlas0: tmu@10060000 {
>> + compatible = "samsung,exynos5433-tmu";
>> + reg = <0x10060000 0x200>;
>> + interrupts = <0 95 0>;
>
> For some interrupts definitions, you are using the GIC interrupt type macros
> while for others like this you are using the constant numbers. I think would
> be better to use the macros consistently (i.e: interrupts = <GIC_SPI 95 0>).
OK. I'll use the GIC_SPI at all of them.
>
> [snip]
>
>> + mipi_phy: video-phy@105C0708 {
>> + compatible = "samsung,exynos5433-mipi-video-phy";
>> + #phy-cells = <1>;
>> + samsung,pmu-syscon = <&pmu_system_controller>;
>> + samsung,cam0-sysreg = <&syscon_cam0>;
>> + samsung,cam1-sysreg = <&syscon_cam1>;
>> + samsung,disp-sysreg = <&syscon_disp>;
>> + };
>
> This node has a unit name but it doesn't have a reg property so dtc will
> warn about the mismatch when executed with W=1.
The mipi_phy address are included in the PMU (base 0x105c_0000).
There is no memory map for only MIPI_PHY. Instead, the mipi_phy driver[1]
uses the regmap (pmu, syscon_cam0/1/disp).
[1] drivers/phy/phy-exynos-mipi-video.c don't use
Also, the first MIPI_PHY's address is 0x105c0710. I'll fix it.
If you want to add the 'reg' property, I can add DT node as following:
mipi_phy: video-phy@105c0710 {
reg = <0x105c0710 0x0>;
compatible = "samsung,exynos5433-mipi-video-phy";
...
};
But it looks strange because the mipi_phy driver[1] never gets
the base address with of_iomap().
>
> [snip]
>
>> + usbdrd30: usb@15400000 {
>> + compatible = "samsung,exynos5250-dwusb3";
>> + clocks = <&cmu_fsys CLK_ACLK_USBDRD30>,
>> + <&cmu_fsys CLK_SCLK_USBDRD30>;
>> + clock-names = "usbdrd30", "usbdrd30_susp_clk";
>> + assigned-clocks =
>> + <&cmu_fsys CLK_MOUT_SCLK_USBDRD30_USER>,
>> + <&cmu_top CLK_MOUT_SCLK_USBDRD30>,
>> + <&cmu_top CLK_DIV_SCLK_USBDRD30>;
>> + assigned-clock-parents =
>> + <&cmu_top CLK_SCLK_USBDRD30_FSYS>,
>> + <&cmu_top CLK_MOUT_BUS_PLL_USER>;
>> + assigned-clock-rates = <0>, <0>, <66700000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> + status = "disabled";
>> +
>
> Ditto, the node has unit address but no reg property.
The usbdrd[2] driver don't map the base address.
So, this DT node don't include any code calling the of_iomap().
[2] drivers/usb/dwc3/dwc3-exynos.c
But, the usbdrd's base address is 0x15400000.
>
>> + dwc3 {
>> + compatible = "snps,dwc3";
>> + reg = <0x15400000 0x10000>;
>
> Ditto, the node doesn't have a unit address but has reg property.
OK. I'll modify it as following:
dwc3@15400000 {
>
>> + interrupts = <0 231 0>;
>> + phys = <&usbdrd30_phy 0>, <&usbdrd30_phy 1>;
>> + phy-names = "usb2-phy", "usb3-phy";
>> + };
>> + };
>> +
>> +
>> + usbhost30: usb@15a00000 {
>> + compatible = "samsung,exynos5250-dwusb3";
>> + clocks = <&cmu_fsys CLK_ACLK_USBHOST30>,
>> + <&cmu_fsys CLK_SCLK_USBHOST30>;
>> + clock-names = "usbdrd30", "usbdrd30_susp_clk";
>> + assigned-clocks =
>> + <&cmu_fsys CLK_MOUT_SCLK_USBHOST30_USER>,
>> + <&cmu_top CLK_MOUT_SCLK_USBHOST30>,
>> + <&cmu_top CLK_DIV_SCLK_USBHOST30>;
>> + assigned-clock-parents =
>> + <&cmu_top CLK_SCLK_USBHOST30_FSYS>,
>> + <&cmu_top CLK_MOUT_BUS_PLL_USER>;
>> + assigned-clock-rates = <0>, <0>, <66700000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + ranges;
>> + status = "disabled";
>> +
>
> Ditto, the node has unit address but no reg property.
This case is same with above 'usbdrd30'.
>
>> + usbdrd_dwc3_0: dwc3 {
>> + compatible = "snps,dwc3";
>> + reg = <0x15a00000 0x10000>;
>
> Ditto, the node doesn't have a unit address but has reg property.
I'll modify it as following:
usbdrd_dwc3_0: dwc3@15a00000 {
>
>> + interrupts = <0 244 0>;
>> + phys = <&usbhost30_phy 0>, <&usbhost30_phy 1>;
>> + phy-names = "usb2-phy", "usb3-phy";
>> + };
>> + };
>> +
>
> [snip]
>
>> + audio-subsystem {
I'll modify it as following:
audio-subsystem@11400000 {
>> + compatible = "samsung,exynos5433-lpass";
>> + reg = <0x11400000 0x100>, <0x11500000 0x08>;
>
> Ditto, the node doesn't have a unit address but has reg property.
>
> Reviewed-by: Javier Martinez Canillas <javier@xxxxxxxxxxxxxxx>
Thanks for your review.
--
Best Regards,
Chanwoo Choi
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
