On Mon, Dec 02, 2013 at 03:52:59PM +0000, Gerhard Sittig wrote: > fix a typo in the "clock specifiers" discussion, > clarify that clock specifiers (the integer cells > part that goes with the phandle) may be empty > > Cc: Rob Herring <rob.herring@xxxxxxxxxxx> > Cc: Pawel Moll <pawel.moll@xxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Stephen Warren <swarren@xxxxxxxxxxxxx> > Cc: Ian Campbell <ijc+devicetree@xxxxxxxxxxxxxx> > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Gerhard Sittig <gsi@xxxxxxx> > --- > > this may sound like nit picking, but from an earlier explanation by Mark > Rutland I learned that a reference always consists of a phandle and a > specifier, that the specifier is the sequence of integer cells that > accompany the phandle, and that the phandle "by intuition might be > expected to" be part of the specifier but specificly is not (and shall > not, to keep the existing documentation consistent) > > since I was fixing the typo, and had the above information, I could not > resist but had to add the "may be zero cells" detail in bypassing It would be nice to move a bit of this into the patch title and description that'll survive as the commit (the title's a bit vague). > > found no other issue in this file -- don't worry, won't emit an endless > stream of tiny trivial changes, this one is all there is :) > > Documentation/devicetree/bindings/clock/clock-bindings.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/clock/clock-bindings.txt b/Documentation/devicetree/bindings/clock/clock-bindings.txt > index eb65d417f8c4..7c52c29d99fa 100644 > --- a/Documentation/devicetree/bindings/clock/clock-bindings.txt > +++ b/Documentation/devicetree/bindings/clock/clock-bindings.txt > @@ -5,7 +5,7 @@ Sources of clock signal can be represented by any node in the device > tree. Those nodes are designated as clock providers. Clock consumer > nodes use a phandle and clock specifier pair to connect clock provider > outputs to clock inputs. Similar to the gpio specifiers, a clock > -specifier is an array of one more more cells identifying the clock > +specifier is an array of zero, one or more cells identifying the clock To nit pick slightly further, how about just "zero or more"? Otherwise, this looks good to me! Acked-by: Mark Rutland <mark.rutland@xxxxxxx> > output on a device. The length of a clock specifier is defined by the > value of a #clock-cells property in the clock provider node. > > -- > 1.7.10.4 > > -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
