Hi Mark, On Wed, 2013-11-27 at 16:28 +0000, Mark Brown wrote: > On Wed, Nov 27, 2013 at 04:13:23PM +0000, Lee Jones wrote: > > On Wed, 27 Nov 2013, Mark Brown wrote: > > > > The usual thing to do is of_get_child_by_name() on the parent to get the > > > container to search in. > > > What do you mean when you say 'usual thing'? Only the max8998 does > > this currently. IMHO the better way to do it for MFD devices is > > provide a compatible string and let the framework does the rest for > > you. > > No, as3722, Palmas and three of the TPS chips do the same thing. If it > were a purely Linux-internal thing I'd probably agree with you but as it > is we'd just be adding compatible strings in everyone's DTs to save one > line of code in the kernel. Lee applied the MFD part of max14577, including the "of_compatible" of max14577-regulator. Do you wish me to change the patch to previous version using of_get_child_by_name()? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
