Hi, (trying again in plaintext, sorry for the HTML spam...) A bit tricky to reply to two mails in one, as I think my reply relates to both, but here it goes. On 1 September 2016 at 04:42, Chen-Yu Tsai <wens@xxxxxxxx> wrote: > On Thu, Sep 1, 2016 at 3:30 AM, <jorik@xxxxxxxxxxxxxx> wrote: >> From: Jorik Jonker <jorik@xxxxxxxxxxxxxx> >> >> This enables the i2c0/i2c1 peripherals of the SoC. There is actually a third >> controller, but I do not have a board on hands on which i2c2 is exposed in such >> a way that I can verify that it works. > > If they are listed in the manual, and the interrupts, clocks, resets, pins > all exist, that is good enough for me. That sounds sensible, I will do that in v3. > These pinmuxes are the only ones possible for each peripheral. > Please drop the _a suffix and the @0 address for both of them. Agreed. But: I think the same goes for UARTs 0-3, of which 0-1 have a pinmux following the _a / @0 syntax in current kernel. There are not really options here, except leaving out RTS/CTS on uarts1-3, which one could do in a board-specific pinmux. Moreover, I could put all the pinmux-peripheral associations for H3 in the DTSI, removing them from the DTS files (including already existing), as the associations themselves are not really board specific, right? Best, Jorik -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
