On Sun, Dec 01, 2013 at 12:06:49PM -0700, Stephen Warren wrote: > On 11/29/2013 05:23 AM, Thierry Reding wrote: > > On Fri, Nov 15, 2013 at 01:53:57PM -0700, Stephen Warren wrote: > > [...] > >> diff --git > >> a/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt > >> b/Documentation/devicetree/bindings/gpu/nvidia,tegra20-host1x.txt > > > >> > [...] > >> + - resets : Must contain an entry for each entry in > >> reset-names. + See ../reset/reset.txt for details. + - > >> reset-names : Must include the following entries: + - dc > > > > For consistency with this, the clock-names entry for the first > > clock in this node should then be "dc" as well. > > The dc driver gets the clock by name, so this isn't a requirement. Right, but like I've said in another reply, I'd very much like for this to be fixed up so we don't have to mess around with per-instance names for clocks. So instead of naming the first clock in the display controller node "disp", we could rename it to "dc" for consistency with the reset bindings. > >> diff --git > >> a/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.txt > >> b/Documentation/devicetree/bindings/sound/nvidia,tegra30-ahub.txt > > > >> > [...] > >> - - spdif_in + - spdif > > > > Why is this renamed? > > There are two separate clocks for the SPDIF input and output modules, > but just a single reset. I also realized that when reviewing one of the subsequent patches. Thierry
Attachment:
pgpQQEZWZfT8j.pgp
Description: PGP signature
