Hi Milo, On Fri, Aug 26, 2016 at 05:00:37PM +0900, Milo Kim wrote: > On 08/26/2016 04:10 PM, Maxime Ripard wrote: > >>+ uart1_pins_a: uart1@0 { > >>> + allwinner,pins = "PG6", "PG7"; > >>> + allwinner,function = "uart1"; > >>> + allwinner,drive = <SUN4I_PINCTRL_10_MA>; > >>> + allwinner,pull = <SUN4I_PINCTRL_NO_PULL>; > >>> + }; > >>> + > >Our policy is that we don't introduce new pinctrl nodes that are not > >used by any board to avoid bloating the DT too much with unused nodes. > > > >If you have a board using it, please submit that change as well. > > OK, I agree. > > However, this pinmux is only useful in case PA5 is assigned for PWM. > PA5 is commonly used for UART0_RX, so I'd like to add UART1 node into *.dts > and disable it (status = "disabled"). Does it make sense? I guess UART1 is either used or not used on that board. In the former case, it should be enabled, in the latter, left out of the DTS entirely. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature