On Fri, Nov 29, 2013 at 12:11 PM, Jonas Jensen <jonas.jensen@xxxxxxxxx> wrote:
> Add GPIO driver for MOXA ART SoCs.
>
> Signed-off-by: Jonas Jensen <jonas.jensen@xxxxxxxxx>
OK this v6 version is looking *really good* so I have
applied it, couldn't hesitate.
> +static struct gpio_chip moxart_template_chip = {
> + .label = "moxart-gpio",
> + .request = moxart_gpio_request,
> + .free = moxart_gpio_free,
> + .direction_input = moxart_gpio_direction_input,
> + .direction_output = moxart_gpio_direction_output,
> + .set = moxart_gpio_set,
> + .get = moxart_gpio_get,
> + .base = 0,
> + .ngpio = 32,
> + .can_sleep = 0,
> +};
No need to initialized unused fields to zero, that is by
default. But no big deal.
> +static const struct of_device_id moxart_gpio_match[] = {
> + { .compatible = "moxa,moxart-gpio" },
> + { }
> +};
This vendor prefix does not exist in
Documentation/devicetree/bindings/vendor-prefixes.txt
Please send a follow-up patch adding it and I can merge
that through the GPIO tree as well.
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
