Hi, On Fri, Aug 19, 2016 at 09:13:31AM +0800, Wenyou Yang wrote: > - Fix the 'dev' argument of devm_request_irq() to pdev->dev.parent. This is not a fix. > + ret = devm_request_irq(pdev->dev.parent, irq, act8945a_status_changed, > + IRQF_TRIGGER_FALLING, "act8945a_interrupt", > + charger); > + if (ret) { > + dev_err(&pdev->dev, "failed to request nIRQ pin IRQ\n"); > + return ret; > + } This will result in the irq not being free'd during device remove, but when the parent device is removed. -- Sebastian
Attachment:
signature.asc
Description: PGP signature