Re: [Patch v2 4/5] ARM: dts: msm8974-hammerhead: Add regulator nodes for hammerhead

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon 18 Jul 22:04 PDT 2016, Bhushan Shah wrote:

> Cc: Andy Gross <andy.gross@xxxxxxxxxx>
> Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> Cc: David Brown <david.brown@xxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>
> Cc: Mark Rutland <mark.rutland@xxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxx>
> Cc: linux-arm-msm@xxxxxxxxxxxxxxx
> Cc: linux-soc@xxxxxxxxxxxxxxx
> Cc: devicetree@xxxxxxxxxxxxxxx
> Signed-off-by: Bhushan Shah <bshah@xxxxxxx>
> ---
>  .../dts/qcom-msm8974-lge-nexus5-hammerhead.dts     | 212 +++++++++++++++++++++
>  1 file changed, 212 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> index 68f3a8a..066a8dc 100644
> --- a/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> +++ b/arch/arm/boot/dts/qcom-msm8974-lge-nexus5-hammerhead.dts
> @@ -1,6 +1,8 @@
>  #include "qcom-msm8974.dtsi"
>  #include "qcom-pm8841.dtsi"
>  #include "qcom-pm8941.dtsi"
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
>  
>  / {
>  	model = "LGE MSM 8974 HAMMERHEAD";
> @@ -13,6 +15,216 @@
>  	chosen {
>  		stdout-path = "serial0:115200n8";
>  	};
> +
> +	smd {
> +		rpm {
> +			rpm_requests {
> +				pm8841-regulators {
> +					s1 {
> +						regulator-min-microvolt = <675000>;
> +						regulator-max-microvolt = <1050000>;
> +					};
> +
> +					s2 {
> +						regulator-min-microvolt = <500000>;
> +						regulator-max-microvolt = <1050000>;
> +					};
> +
> +					s3 {
> +						regulator-min-microvolt = <1050000>;
> +						regulator-max-microvolt = <1050000>;
> +					};
> +
> +					s4 {
> +						regulator-min-microvolt = <815000>;
> +						regulator-max-microvolt = <900000>;
> +					};
> +				};
> +
> +				pm8941-regulators {
> +					vdd_l1_l3-supply = <&pm8941_s1>;
> +					vdd_l2_lvs1_2_3-supply = <&pm8941_s3>;
> +					vdd_l4_l11-supply = <&pm8941_s1>;
> +					vdd_l5_l7-supply = <&pm8941_s2>;
> +					vdd_l6_l12_l14_l15-supply = <&pm8941_s2>;
> +					vdd_l8_l16_l18_l19-supply = <&vph_pwr_reg>;
> +					vdd_l9_l10_l17_l22-supply = <&vreg_boost>;
> +					vdd_l13_l20_l23_l24-supply = <&vreg_boost>;
> +					vdd_l21-supply = <&vreg_boost>;
> +
> +					s1 {
> +						regulator-min-microvolt = <1300000>;
> +						regulator-max-microvolt = <1300000>;
> +
> +						regulator-always-on;
> +						regulator-boot-on;
> +					};
> +
> +					s2 {
> +						regulator-min-microvolt = <2150000>;
> +						regulator-max-microvolt = <2150000>;
> +
> +						regulator-boot-on;
> +					};
> +
> +					s3 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <1800000>;
> +
> +						regulator-always-on;
> +						regulator-boot-on;
> +					};
> +
> +					l1 {
> +						regulator-min-microvolt = <1225000>;
> +						regulator-max-microvolt = <1225000>;
> +
> +						regulator-always-on;
> +						regulator-boot-on;
> +					};
> +
> +					l2 {
> +						regulator-min-microvolt = <1200000>;
> +						regulator-max-microvolt = <1200000>;
> +					};
> +
> +					l3 {
> +						regulator-min-microvolt = <1225000>;
> +						regulator-max-microvolt = <1225000>;
> +					};
> +
> +					l4 {
> +						regulator-min-microvolt = <1225000>;
> +						regulator-max-microvolt = <1225000>;
> +					};
> +
> +					l5 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <1800000>;
> +					};
> +
> +					l6 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <1800000>;
> +
> +						regulator-boot-on;
> +					};
> +
> +					l7 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <1800000>;
> +
> +						regulator-boot-on;
> +					};
> +
> +					l8 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <1800000>;
> +					};
> +
> +					l9 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <2950000>;
> +					};
> +
> +					l10 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <2950000>;
> +					};
> +
> +					l11 {
> +						regulator-min-microvolt = <1300000>;
> +						regulator-max-microvolt = <1300000>;
> +					};
> +
> +					l12 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <1800000>;
> +
> +						regulator-always-on;
> +						regulator-boot-on;
> +					};
> +
> +					l13 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <2950000>;
> +
> +						regulator-boot-on;
> +					};
> +
> +					l14 {
> +						regulator-min-microvolt = <1800000>;
> +						regulator-max-microvolt = <1800000>;
> +					};
> +
> +					l15 {
> +						regulator-min-microvolt = <2050000>;
> +						regulator-max-microvolt = <2050000>;
> +					};
> +
> +					l16 {
> +						regulator-min-microvolt = <2700000>;
> +						regulator-max-microvolt = <2700000>;
> +					};
> +
> +					l17 {
> +						regulator-min-microvolt = <2850000>;
> +						regulator-max-microvolt = <2850000>;
> +					};
> +
> +					l18 {
> +						regulator-min-microvolt = <2850000>;
> +						regulator-max-microvolt = <2850000>;
> +					};
> +
> +					l19 {
> +						regulator-min-microvolt = <3000000>;
> +						regulator-max-microvolt = <3300000>;
> +					};
> +
> +					l20 {
> +						regulator-min-microvolt = <2950000>;
> +						regulator-max-microvolt = <2950000>;
> +
> +						regulator-boot-on;
> +					};
> +
> +					l21 {
> +						regulator-min-microvolt = <2950000>;
> +						regulator-max-microvolt = <2950000>;
> +
> +						regulator-boot-on;
> +					};
> +
> +					l22 {
> +						regulator-min-microvolt = <3000000>;
> +						regulator-max-microvolt = <3300000>;
> +					};
> +
> +					l23 {
> +						regulator-min-microvolt = <3000000>;
> +						regulator-max-microvolt = <3000000>;
> +					};
> +
> +					l24 {
> +						regulator-min-microvolt = <3075000>;
> +						regulator-max-microvolt = <3075000>;
> +
> +						regulator-boot-on;
> +					};
> +				};
> +			};
> +		};
> +	};

Looks good, for this part:

Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>

> +
> +	vreg_boost {
> +		gpio = <&pm8941_gpios 21 GPIO_ACTIVE_HIGH>;
> +		enable-active-high;
> +
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&boost_bypass_n_pin>;
> +	};

Please update the Honami patch and drop this node.

Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux