On Mon 18 Jul 22:04 PDT 2016, Bhushan Shah wrote: > Cc: Andy Gross <andy.gross@xxxxxxxxxx> > Cc: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > Cc: David Brown <david.brown@xxxxxxxxxx> > Cc: Rob Herring <robh+dt@xxxxxxxxxx> > Cc: Mark Rutland <mark.rutland@xxxxxxx> > Cc: Russell King <linux@xxxxxxxxxxxxxxx> > Cc: linux-arm-msm@xxxxxxxxxxxxxxx > Cc: linux-soc@xxxxxxxxxxxxxxx > Cc: devicetree@xxxxxxxxxxxxxxx > Signed-off-by: Bhushan Shah <bshah@xxxxxxx> > --- > arch/arm/boot/dts/qcom-msm8974.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi > index 570028c..b5e80a4 100644 > --- a/arch/arm/boot/dts/qcom-msm8974.dtsi > +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi > @@ -615,4 +615,14 @@ > regulator-always-on; > regulator-boot-on; > }; > + > + vph_pwr_reg: vph-pwr-reg { Please change this to: vreg_vph_pwr: vreg-vph-pwr { ... And you have my Reviewed-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx> > + compatible = "regulator-fixed"; > + regulator-name = "vph-pwr"; But this name is good. > + > + regulator-min-microvolt = <3600000>; > + regulator-max-microvolt = <3600000>; > + > + regulator-always-on; > + }; > }; Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html