On Wed, Jul 27, 2016 at 10:36:49AM +0200, Jean-Francois Moine wrote: > On Wed, 27 Jul 2016 09:40:20 +0200 > Maxime Ripard <maxime.ripard@xxxxxxxxxxxxxxxxxx> wrote: > > > > > Parenting functions would also not work as expected, > > > > clk_hw_get_parent_by_index being the obvious example, in that case > > > > returning the empty string for an invalid parent, while it should > > > > really return NULL. > > > > > > I don't see why the clock should be orphan. > > > Then, when a parent is "", clk_hw_get_parent_by_index() returns NULL. > > > > Why? It should return NULL when there's no parent, while you > > explicitly registered a parent. > > "" is not an existing parent. It could be "none" / "dum" / "toto" / ... > with the same result: 'this index cannot be used in mux'. And the clock is marked as orphan, while it really isn't. -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
Attachment:
signature.asc
Description: PGP signature