On Wed, Jul 20, 2016 at 02:15:33PM -0500, Rob Herring wrote: > On Wed, Jul 20, 2016 at 10:03:18AM +0200, LABBE Corentin wrote: > > This patch adds documentation for Device-Tree bindings for the > > Allwinner sun8i-emac driver. > > > > Signed-off-by: LABBE Corentin <clabbe.montjoie@xxxxxxxxx> > > --- > > .../bindings/net/allwinner,sun8i-emac.txt | 65 ++++++++++++++++++++++ > > 1 file changed, 65 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt > > > > diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt > > new file mode 100644 > > index 0000000..4bf4e53 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-emac.txt > > @@ -0,0 +1,65 @@ > > +* Allwinner sun8i EMAC ethernet controller > > + > > +Required properties: > > +- compatible: "allwinner,sun8i-a83t-emac", "allwinner,sun8i-h3-emac", > > + or "allwinner,sun50i-a64-emac" > > List one per line. > ok > > +- reg: address and length of the register sets for the device. > > +- reg-names: should be "emac" and "syscon", matching the register sets > > +- interrupts: interrupt for the device > > +- clocks: A phandle to the reference clock for this device > > +- clock-names: should be "ahb" > > +- resets: A phandle to the reset control for this device > > +- reset-names: should be "ahb" > > +- phy-mode: See ethernet.txt > > +- phy or phy-handle: See ethernet.txt > > +- #address-cells: shall be 1 > > +- #size-cells: shall be 0 > > + > > +"allwinner,sun8i-h3-emac" also requires: > > +- clocks: an extra phandle to the reference clock for the EPHY > > +- clock-names: an extra "ephy" entry matching the clocks property > > +- resets: an extra phandle to the reset control for the EPHY > > +- resets-names: an extra "ephy" entry matching the resets property > > + > > +See ethernet.txt in the same directory for generic bindings for ethernet > > +controllers. > > + > > +The device node referenced by "phy" or "phy-handle" should be a child node > > +of this node. See phy.txt for the generic PHY bindings. > > + > > +Optional properties: > > +- phy-supply: phandle to a regulator if the PHY needs one > > +- phy-io-supply: phandle to a regulator if the PHY needs a another one for I/O. > > + This is sometimes found with RGMII PHYs, which use a second > > + regulator for the lower I/O voltage. > > I previously said these should go in the phy node, and you said you > would remove them. > > Rob Sorry, I forgot to remove them. I have removed them now. Regards Thanks LABBE Corentin -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html