On Monday, July 11, 2016 10:13:54 AM CEST Wan Zongshun wrote: > > On 2016年07月11日 06:17, Arnd Bergmann wrote: > > On Sunday, July 10, 2016 3:42:21 PM CEST Wan Zongshun wrote: > >> + > >> +Required properties: > >> +- compatible : Should be "nuvoton,nuc970-tmr" > >> +- reg : Address and length of the register set > >> +- clocks : Reference on the timer input clock > >> +- interrupts : Reference to the timer interrupt > >> + > >> +Example: > >> + > >> +tmr@0xb8001000 { > > > > The name should be "timer", not "tmr", and the address should > > not contain a leading "0x". > > Ok, so all dts addresses has no need contain a leading "0x"? In properties, you need the leading 0x for hexadecimal numbers, in the node name the portion after the "@" depends on the bus, but is usually just the value of the address in hexadecimal without the leading 0x. > > > >> + compatible = "nuvoton,nuc970-tmr"; > >> + reg = <0xb8001000 0x1000>; > >> + interrupts = <16>; > >> + clocks = <&clks TIMER0_GATE>, > >> + <&clks TIMER1_GATE>; > >> + clock-names = "timer0", "timer1"; > >> +}; > > > > The clocks/clock-names description does not match the example: > > you only define a single clock in the required properties, but > > have two separate inputs in the example. Please fix one or the > > other. > > Two clocks are necessary, so I only need modify this description like? > > Required properties: > clocks : Reference on the timer input clock, This list should be 2 > clocks, the order is timer0 , timer1. > > Is it ok? Yes, looks good. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html