On 18 July 2016 at 07:53, Peter Chen <hzpeterchen@xxxxxxxxx> wrote: > On Mon, Jul 18, 2016 at 07:57:34AM +0200, Rafał Miłecki wrote: >> On 18 July 2016 at 07:40, Peter Chen <hzpeterchen@xxxxxxxxx> wrote: >> > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: >> >> On 18 July 2016 at 04:31, Peter Chen <hzpeterchen@xxxxxxxxx> wrote: >> >> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> >> >> + >> >> >> +usbport trigger: >> >> >> +- usb-ports : List of USB ports that usbport should observed for turning on a >> >> >> + given LED. >> >> >> + >> >> > >> >> > %s/should/should be >> >> >> >> Thanks. >> >> >> >> >> >> >> diff --git a/drivers/leds/trigger/ledtrig-usbport.c b/drivers/leds/trigger/ledtrig-usbport.c >> >> >> new file mode 100644 >> >> >> index 0000000..97b064c >> >> >> --- /dev/null >> >> >> +++ b/drivers/leds/trigger/ledtrig-usbport.c >> >> >> @@ -0,0 +1,206 @@ >> >> >> +/* >> >> >> + * USB port LED trigger >> >> >> + * >> >> >> + * Copyright (C) 2016 Rafał Miłecki <rafal.milecki@xxxxxxxxx> >> >> >> + * >> >> >> + * This program is free software; you can redistribute it and/or modify >> >> >> + * it under the terms of the GNU General Public License as published by >> >> >> + * the Free Software Foundation; either version 2 of the License, or (at >> >> >> + * your option) any later version. >> >> >> + */ >> >> > > > In your COPYRIGHT, it says "or any later version". But afaik, It should > not be on GPL v3. If one picks my code, modifies it, relicenses it using GPL v3, we can't include it anymore. It's the same story as with BSD systems and their BSD licenses. If one picks e.g. BSD 3-clause licensed code, makes it GPL, releases it (e.g. by putting in Linux), BSD can't use it anymore. Still, this license is GPL v2 compatible and as is it can be included in the Linux. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html