On 18 July 2016 at 07:40, Peter Chen <hzpeterchen@xxxxxxxxx> wrote: > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafał Miłecki wrote: >> On 18 July 2016 at 04:31, Peter Chen <hzpeterchen@xxxxxxxxx> wrote: >> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafał Miłecki wrote: >> >> + >> >> +usbport trigger: >> >> +- usb-ports : List of USB ports that usbport should observed for turning on a >> >> + given LED. >> >> + >> > >> > %s/should/should be >> >> Thanks. >> >> >> >> diff --git a/drivers/leds/trigger/ledtrig-usbport.c b/drivers/leds/trigger/ledtrig-usbport.c >> >> new file mode 100644 >> >> index 0000000..97b064c >> >> --- /dev/null >> >> +++ b/drivers/leds/trigger/ledtrig-usbport.c >> >> @@ -0,0 +1,206 @@ >> >> +/* >> >> + * USB port LED trigger >> >> + * >> >> + * Copyright (C) 2016 Rafał Miłecki <rafal.milecki@xxxxxxxxx> >> >> + * >> >> + * This program is free software; you can redistribute it and/or modify >> >> + * it under the terms of the GNU General Public License as published by >> >> + * the Free Software Foundation; either version 2 of the License, or (at >> >> + * your option) any later version. >> >> + */ >> > >> > GPL v2 only. >> > >> >> +MODULE_AUTHOR("Rafał Miłecki <rafal.milecki@xxxxxxxxx>"); >> >> +MODULE_DESCRIPTION("USB port trigger"); >> >> +MODULE_LICENSE("GPL"); >> > >> > GPL v2 >> >> What's the reason for this? I don't have any real preference, but I >> never heard heard about kernel/Linux preference neither. >> > > https://en.wikipedia.org/wiki/Linux_kernel Well, Linux is released under GPL v2, I'm well aware of that. It means all its code needs to be GPL v2 compatible. There are multiple compatible licenses: MIT, BSD 3-clause, BSD 2-clause. The one I used allows treating code as GPL V2 as well. I could release this code using MIT and it should be acceptable as well. I still don't see what's wrong with the picked license. -- Rafał -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html