Hi Paul, On dim., juil. 10 2016, Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > On Thu, Jul 7, 2016 at 6:37 PM, Gregory CLEMENT > <gregory.clement@xxxxxxxxxxxxxxxxxx> wrote: >> This clock is the parent of all the Armada 3700 clocks. It is a fixed >> rate clock which depends on the gpio configuration read when resetting >> the SoC. >> >> Signed-off-by: Gregory CLEMENT <gregory.clement@xxxxxxxxxxxxxxxxxx> >> --- >> drivers/clk/mvebu/Kconfig | 3 ++ >> drivers/clk/mvebu/Makefile | 1 + >> drivers/clk/mvebu/armada-37xx-xtal.c | 98 ++++++++++++++++++++++++++++++++++++ >> 3 files changed, 102 insertions(+) >> create mode 100644 drivers/clk/mvebu/armada-37xx-xtal.c >> >> diff --git a/drivers/clk/mvebu/Kconfig b/drivers/clk/mvebu/Kconfig >> index 3165da77d525..fddc8ac5faff 100644 >> --- a/drivers/clk/mvebu/Kconfig >> +++ b/drivers/clk/mvebu/Kconfig >> @@ -24,6 +24,9 @@ config ARMADA_39X_CLK >> bool >> select MVEBU_CLK_COMMON >> >> +config ARMADA_37XX_CLK >> + bool >> + > > Since the driver is not tristate, can you please remove all modular > references from it? With the author and license etc. at the top you > can just delete the last three lines, the DEVICE_TABLE and register > with builtin_platform_driver, and then no need for module.h either. > > Either that, or change it to a tristate, if that use case makes sense. Indeed having these clock drivers as module is not very useful. Let's remove the modular reference. Thanks, Gregory > > Thanks, > Paul. > -- > > >> config ARMADA_XP_CLK >> bool >> select MVEBU_CLK_COMMON >> diff --git a/drivers/clk/mvebu/Makefile b/drivers/clk/mvebu/Makefile >> index 7172ef65693d..4257a36d0219 100644 >> --- a/drivers/clk/mvebu/Makefile >> +++ b/drivers/clk/mvebu/Makefile >> @@ -6,6 +6,7 @@ obj-$(CONFIG_ARMADA_370_CLK) += armada-370.o >> obj-$(CONFIG_ARMADA_375_CLK) += armada-375.o >> obj-$(CONFIG_ARMADA_38X_CLK) += armada-38x.o >> obj-$(CONFIG_ARMADA_39X_CLK) += armada-39x.o >> +obj-$(CONFIG_ARMADA_37XX_CLK) += armada-37xx-xtal.o >> obj-$(CONFIG_ARMADA_XP_ > > [...] -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
