On Tuesday, July 12, 2016 5:06:10 PM CEST Wan Zongshun wrote: > On 2016年07月11日 16:03, Arnd Bergmann wrote: > > On Sunday, July 10, 2016 3:27:26 PM CEST Wan Zongshun wrote: > > I'm still a bit unsure about the set of attributes here. > > > > - The "soc_id" is read from the device tree from the field that contains > > the board name, I think for consistency you should try to map the > > GCR_CHIPID to the name of the SoC and assign that here > > > > - The "machine" is hardcoded to "NUC900EVB", which in turn looks like > > a particular board but not the one you are running on. Maybe read > > that from the DT instead? > > > > - The "revision" is not filled at all, I would suggest using something > > derived from the GCR_CHIPID register here > > > > - you have two nonstandard attributes "chipid" and "version", which > > I'd hope to avoid -- the set of standard attributes is supposed to > > give enough information about the machine, and platform independent > > user space will never read those. > > So, Maybe I can remove those two codes, no need push those information > to user space? > > device_create_file(soc_device_to_device(soc_dev), &nuc900_chipid_attr); > device_create_file(soc_device_to_device(soc_dev), &nuc900_version_attr); > Yes, that would be good. Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
