On Mon, Nov 25, 2013 at 3:17 AM, Thierry Reding <thierry.reding@xxxxxxxxx> wrote: > On Mon, Nov 18, 2013 at 10:54:57AM -0800, Tim Kryger wrote: >> +++ b/Documentation/devicetree/bindings/pwm/bcm-kona-pwm.txt >> @@ -0,0 +1,24 @@ >> +Broadcom's PWM Controller Device Tree bindings > > This sounds somewhat strange, like Broadcom owns the bindings... perhaps > just: > > Broadcom PWM controller device tree bindings > > Or for consistency: > > Broadcom Kona PWM controller device tree bindings Yes that sounds better. >> +Broadcom's Kona PWM Controller has 6 channels > > "controller" and end the sentence with a full stop. Sure. >> +- clocks: clock specifier for the kona pwm external clock > > Please use the correct spelling "PWM" in prose here and elsewhere. Also > you should pick one of "kona", "Kona" or "KONA" and stick with it > consistently. Might also be useful to mention what Kona is. Doesn't > necessarily have to be in the document, but if for nothing else, then > just for my curiosity. Agreed. It should be "Kona" here. Kona roughly defines the set of common IP used on multiple mobile SoCs. >> +- #pwm-cells: should be 2. The first cell specifies the per-chip index >> + of the PWM to use and the second cell is the period in nanoseconds. >> + >> +Refer to pwm/pwm.txt for generic pwm controller node properties. >> + >> +Refer to clocks/clock-bindings.txt for generic clock consumer >> +properties > > This sentence should also end with a full stop. Sure thing. Thanks again. -Tim -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
