Hi Emil, One answer inline below. The rest I leave to Jitao... [snip...] On Fri, Jun 17, 2016 at 3:14 AM, Emil Velikov <emil.l.velikov@xxxxxxxxx> wrote: >> +static ssize_t ps8640_update_fw_store(struct device *dev, >> + struct device_attribute *attr, >> + const char *buf, size_t count) >> +{ >> + struct i2c_client *client = to_i2c_client(dev); >> + struct ps8640 *ps_bridge = i2c_get_clientdata(client); >> + const struct firmware *fw; >> + int error; >> + >> + error = request_firmware(&fw, PS_FW_NAME, dev); > Can the device operate without a firmware ? If not, why is the > firmware loaded so later/after user interaction (via sysfs) ? I don't > recall any other driver in DRM to use such an approach. The PS8640 has internal flash, so it should always already have a working firmware. This sysfs interface is useful for user space initiated field firmware updates. Regards, -Daniel > Regards, > Emil > _______________________________________________ > dri-devel mailing list > dri-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html