On 06/16/2016 11:52 AM, Laxman Dewangan wrote: > Hi Krzysztof/Javier, > Thanks for review of the series. > > I will post the V2 after taking care of all comment. > > One query about the comment. > > Thanks, > Laxman > > On Thursday 16 June 2016 03:24 PM, Krzysztof Kozlowski wrote: >> On 06/15/2016 04:13 PM, Laxman Dewangan wrote: >>> enum chip_name { >>> CHIP_MAX77686, >>> CHIP_MAX77802, >>> + CHIP_MAX77620, >> Now it is more obvious why it is here. However I don't like the >> duplication of device IDs, under different names and different values: >> 1. include/linux/mfd/max77686-private.h >> 2. include/linux/mfd/max77620.h >> 3. here >> >> I was thinking about way of combining it... but these headers are >> different. Unless there will be one header for all three devices. >> >> Anyway, please add the max77686 prefix to the enum. > > so will it be: > > enum max77686_chip_name { > CHIP_MAX77686, > CHIP_MAX77802, > CHIP_MAX77620, > }; > > > Will it be fine here? Yes, looks fine to me. Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html